Replace serde_json with simd_json where supported #3174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## latest #3174 +/- ##
==========================================
- Coverage 86.66% 86.63% -0.04%
==========================================
Files 136 136
Lines 15814 15834 +20
Branches 2713 2713
==========================================
+ Hits 13705 13717 +12
- Misses 1799 1807 +8
Partials 310 310
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found out the simd-json crate supports the same interface as
serde_json, so it is an easy swap for potentially much better perf.Drawbacks are only supported on
x86_64, so need to keepserde_jsonfor all other archs.This PR also shows how spread the use of
serde_json::from_readeracross the codebase is, should probably consolidate into a method on signatures...